Skip to content

Fixed #36192 -- Used semantic HTML for buttons. #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hbrooks wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fixed #36192 -- Used semantic HTML for buttons. #17

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
59b91a8
Fixed #36192 -- Used semantic HTML for buttons.
Antoliny0919 May 24, 2026
3880323
fix failing selenium test.
Antoliny0919 May 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions django/contrib/admin/static/admin/css/base.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,11 +124,14 @@ a:focus {
}

a:not(
[role="button"],
#header a,
#nav-sidebar a,
#content-main.app-list a,
.object-tools a
.object-tools a,
.submit-row a,
.paginator a:not(.showall),
th .text a,
a.button
) {
text-decoration: underline;
}
Expand Down
13 changes: 13 additions & 0 deletions django/contrib/admin/static/admin/css/changelists.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -316,3 +316,16 @@
background-color: SelectedItem;
}
}

#changelist .actions span.question button,
#changelist .actions span.clear button {
background: none;
border: none;
color: var(--link-fg);
cursor: pointer;
}

#changelist .actions span.question button:hover,
#changelist .actions span.clear button:hover {
color: var(--link-hover-color);
}
8 changes: 6 additions & 2 deletions django/contrib/admin/static/admin/css/forms.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -438,8 +438,12 @@ body.popup .submit-row {
border-bottom: 1px solid var(--hairline-color);
}

.inline-group div.add-row a,
.inline-group .tabular tr.add-row td a {
.inline-group div.add-row button,
.inline-group .tabular tr.add-row td button {
border: none;
padding-left: 16px;
cursor: pointer;
color: var(--link-fg);
font-size: 0.75rem;
}

Expand Down
60 changes: 40 additions & 20 deletions django/contrib/admin/static/admin/css/widgets.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -495,7 +495,8 @@ span.clearable-file-input label {
border-bottom: none;
}

.calendar td.selected a {
.calendar td.selected button,
.calendar td.selected button:hover {
background: var(--secondary);
color: var(--button-fg);
}
Expand All @@ -504,33 +505,32 @@ span.clearable-file-input label {
background: var(--darkened-bg);
}

.calendar td.today a {
.calendar td.today button {
font-weight: 700;
}

.calendar td a,
.timelist a {
.calendar td button,
.timelist button {
display: block;
width: 100%;
height: 100%;
background: none;
border: none;
cursor: pointer;
font-weight: 400;
padding: 6px;
text-decoration: none;
color: var(--body-quiet-color);
}

.calendar td a:focus,
.timelist a:focus,
.calendar td a:hover,
.timelist a:hover {
.calendar td button:focus,
.timelist button:focus,
.calendar td button:hover,
.timelist button:hover {
background: var(--primary);
color: white;
}

.calendar td a:active,
.timelist a:active {
background: var(--header-bg);
color: white;
}

.calendarnav {
font-size: 0.625rem;
text-align: center;
Expand All @@ -539,10 +539,7 @@ span.clearable-file-input label {
padding: 1px 3px;
}

.calendarnav a:link,
#calendarnav a:visited,
#calendarnav a:focus,
#calendarnav a:hover {
#calendarnav button:hover {
color: var(--body-quiet-color);
}

Expand All @@ -559,6 +556,8 @@ span.clearable-file-input label {
.calendarbox .calendarnav-next {
display: block;
position: absolute;
border: none;
cursor: pointer;
top: 8px;
width: 15px;
height: 15px;
Expand Down Expand Up @@ -590,9 +589,30 @@ span.clearable-file-input label {
background: var(--close-button-hover-bg);
}

.calendar-cancel a {
color: var(--button-fg);
.calendar-cancel button {
display: block;
padding: 4px 0;
width: 100%;
height: 100%;
background: none;
border: none;
color: var(--button-fg);
cursor: pointer;
}

.datetimeshortcuts button,
.calendar-shortcuts button {
background: none;
border: none;
cursor: pointer;
color: var(--link-fg);
}

.datetimeshortcuts button:hover,
.datetimeshortcuts button:focus,
.calendar-shortcuts button:hover,
.calendar-shortcuts button:focus {
color: var(--link-hover-color);
}

ul.timelist,
Expand Down
4 changes: 2 additions & 2 deletions django/contrib/admin/static/admin/js/actions.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,7 +121,7 @@
});

document
.querySelectorAll(options.acrossQuestions + " a")
.querySelectorAll(options.acrossQuestions + " button")
.forEach(function (el) {
el.addEventListener("click", function (event) {
event.preventDefault();
Expand All @@ -136,7 +136,7 @@
});

document
.querySelectorAll(options.acrossClears + " a")
.querySelectorAll(options.acrossClears + " button")
.forEach(function (el) {
el.addEventListener("click", function (event) {
event.preventDefault();
Expand Down
Loading