fix(charts): sanitize tooltip HTML across nvd3, rose and partition plugins#9
Open
hbrooks wants to merge 2 commits into
Open
fix(charts): sanitize tooltip HTML across nvd3, rose and partition plugins#9hbrooks wants to merge 2 commits into
hbrooks wants to merge 2 commits into
Conversation
Route the annotation tooltip HTML through DOMPurify before it is passed to d3-tip's .html() sink, matching the sanitization already applied in sibling tooltip helpers in this file.
…ugins Expand the SEC-125 cluster's annotation-tooltip fix to cover every confirmed tooltip HTML sink in the cluster, plus the default nvd3 tooltip path that shares the same root cause. - legacy-preset-chart-nvd3/src/utils.ts: wrap generateBubbleTooltipContent, generateMultiLineTooltipContent, and wrapTooltip output with DOMPurify; flip getFormattedKey shouldDompurify to true for consistency. - legacy-plugin-chart-rose/src/Rose.ts: sanitize series keys in tooltipData and legendData via sanitizeHtml. - legacy-plugin-chart-partition/src/Partition.ts: sanitize tooltip HTML with sanitizeHtml(t) before tip.html(t). - legacy-preset-chart-nvd3/test/utils.test.ts: regression tests for the three nvd3 utils helpers (script and img onerror payloads). - scripts/oxlint.sh: drive-by; last line was '[ -n "$output" ] && echo "$output"' which under 'set -e' aborts the script when oxlint succeeds with empty output. Replaced with an explicit 'if [ -n "$output" ]; then ... fi' so a clean lint run no longer fails the pre-commit hook. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Originally PR apache#40502 in apache/superset by @sha174n