Added fill placeholders function#35
Open
albertdahlin wants to merge 1 commit intoelm-community:masterfrom
Open
Added fill placeholders function#35albertdahlin wants to merge 1 commit intoelm-community:masterfrom
albertdahlin wants to merge 1 commit intoelm-community:masterfrom
Conversation
Collaborator
|
Looks useful to me, especially when working with translated strings. Would be nice to have some tests, though! |
Author
|
I will be happy to write some tests. Are you using the tests in /tests dir? I thought they were all 0.18 but maybe that does not matter? |
Collaborator
|
Honestly I'm not sure what the status of the tests is currently. I'll have to take a look but I'm short on time. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have found this function quite useful for me, maybe it could be useful for others?
Maybe there is a better name for it?
will result in
"Page 2 of 100"