Adapt String.words to handle blank text in a more standard way.#45
Open
jbrains wants to merge 1 commit intoelm-community:masterfrom
Open
Adapt String.words to handle blank text in a more standard way.#45jbrains wants to merge 1 commit intoelm-community:masterfrom
jbrains wants to merge 1 commit intoelm-community:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I propose providing a function for
wordsthat answers[]for blank text, because there are no words in a blank piece of text and because the empty string is, by common understanding, not a word.I don't like the way I wrote the test, because I couldn't figure out how to fuzz a non-blank multiline string. I'd be very happy to take your suggestions about how to do that.
Since this is my first contribution, I don't know what I might have done that goes against house conventions. Just tell me what you need me to change, if anything.