Add a function for parsing all remaining path segments.#31
Open
EdSchouten wants to merge 2 commits intoelm:masterfrom
Open
Add a function for parsing all remaining path segments.#31EdSchouten wants to merge 2 commits intoelm:masterfrom
EdSchouten wants to merge 2 commits intoelm:masterfrom
Conversation
added 2 commits
April 11, 2019 09:21
The parser state is not exposed by this module. Considering that nothing in the parser relies on it, we can safely omit it.
Having an operation like this is useful for cases where you need to forward/process arbitrary requests for a certain path prefix. Fixes: elm#9
|
ah, I noticed the same thing as you with the unused visited field and made #50 before I realized it was here as well. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Having an operation like this is useful for cases where you need to forward/process arbitrary requests for a certain path prefix. While there, make a tiny cleanup to the parser by removing an unused field in the parser state.
Fixes: #9