Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There were a couple of problems in
examples/Example.elmthat I wanted to help out with:Debug.toString, which is not considered suitable for production use (afaik at least by the community). I wrote arouteToStringfunction instead, which does add some boilerplate, but I think that the use ofDebug.toStringshould be discouraged. On the other hand, the history tab is, in a way, debugging. I'm open to changing it or not, but I do think thatDebug.toStringshould be, as previously mentioned, discouraged."Uknown URL")These are all things that aren't major issues, and a lot of it is somewhat opinionated on my behalf. I'm more than happy to drop some (or all) of them, but I really do think this could help out.