Fix drone state computation when the Emacs directory is not git root#183
Merged
tarsius merged 1 commit intoJun 3, 2026
Merged
Conversation
"git diff-index" emits paths relative to root. Therefore, if `borg-user-emacs-directory' is a subdirectory, it is not appropriate to operate in that directory.
tarsius
force-pushed
the
fix-drone-states-default-directory
branch
from
b923e7e to
04fc19e
Compare
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
git diff-indexemits a path relative to root. If root differed fromborg-user-emacs-directory,(expand-file-name module)expanded tothe wrong path. This led to the version always being REMOVE on
borg-insert-update-messageif the Emacs directory was not the sameas the git directory.
This pull request instead sets default directory in the drone state
computation to
borg-top-level-directory.