Potential fix for code scanning alert no. 43: Clear-text logging of sensitive information#1
Merged
Potential fix for code scanning alert no. 43: Clear-text logging of sensitive information#1
Conversation
…ensitive information Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
eman
commented
Oct 10, 2025
Owner
Author
eman
left a comment
eman
left a comment
There was a problem hiding this comment.
accepting the generated fix.
Co-authored-by: eman <19387+eman@users.noreply.github.com>
Fix broken lint test by installing dependencies and correcting code formatting
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Potential fix for https://github.com/eman/nwp500-python/security/code-scanning/43
To fix the problem, we should avoid logging topic strings that include sensitive data such as the MAC address. Instead, log a generic error message and optionally include only non-sensitive information (e.g., device type, an anonymized topic, or an index). If identification context is needed, consider redacting or masking the MAC address (e.g., showing only the final octet, or replacing with a placeholder).
Specifically, in examples/test_mqtt_messaging.py, replace the print statement on line 125 so that it doesn't log the full topic string.
No additional imports are required.
If context is useful for debugging, log the device type and the subscription attempt index, but exclude the MAC address.
Suggested fixes powered by Copilot Autofix. Review carefully before merging.