Skip to content

Fix blocking call warning in Home Assistant by running MQTT connection setup in executor #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
eman merged 2 commits into from
Oct 17, 2025
Merged

Fix blocking call warning in Home Assistant by running MQTT connection setup in executor #20

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1959c7f
fix: run MQTT connection setup in executor to avoid blocking event loop
eman Oct 17, 2025
9a6a8d2
refactor: use asyncio.to_thread() instead of run_in_executor pattern
eman Oct 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions src/nwp500/mqtt_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -569,10 +569,14 @@ async def connect(self) -> bool:

try:
# Build WebSocket MQTT connection with AWS credentials
self._connection = mqtt_connection_builder.websockets_with_default_aws_signing(
# Run blocking operations in a thread to avoid blocking the event loop
# The AWS IoT SDK performs synchronous file I/O operations during connection setup
credentials_provider = await asyncio.to_thread(self._create_credentials_provider)
self._connection = await asyncio.to_thread(
mqtt_connection_builder.websockets_with_default_aws_signing,
endpoint=self.config.endpoint,
region=self.config.region,
credentials_provider=self._create_credentials_provider(),
credentials_provider=credentials_provider,
client_id=self.config.client_id,
clean_session=self.config.clean_session,
keep_alive_secs=self.config.keep_alive_secs,
Expand Down