Skip to content

Fix DNS resolution in containerized environments using ThreadedResolver #35

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
eman merged 2 commits into from
Nov 15, 2025
Merged

Fix DNS resolution in containerized environments using ThreadedResolver #35

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
99a9845
Fix DNS resolution in containerized environments using ThreadedResolver
eman Nov 15, 2025
ca1773c
Refactor: Extract ThreadedResolver session creation into helper method
eman Nov 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 20 additions & 3 deletions src/nwp500/auth.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -367,7 +367,7 @@ def __init__(
async def __aenter__(self) -> "NavienAuthClient":
"""Async context manager entry."""
if self._owned_session:
self._session = aiohttp.ClientSession(timeout=self.timeout)
self._session = self._create_session()

# Check if we have valid stored tokens
if self._auth_response and self._auth_response.tokens:
Expand All @@ -394,10 +394,24 @@ async def __aexit__(self, exc_type: Any, exc_val: Any, exc_tb: Any) -> None:
if self._owned_session and self._session:
await self._session.close()

def _create_session(self) -> aiohttp.ClientSession:
"""Create an aiohttp ClientSession with ThreadedResolver.

ThreadedResolver uses Python's built-in socket module for DNS
resolution, avoiding dependency on c-ares which can fail in
containerized environments.

Returns:
aiohttp.ClientSession configured with ThreadedResolver
"""
resolver = aiohttp.ThreadedResolver()
connector = aiohttp.TCPConnector(resolver=resolver)
return aiohttp.ClientSession(connector=connector, timeout=self.timeout)

async def _ensure_session(self) -> None:
"""Ensure we have an active session."""
if self._session is None:
self._session = aiohttp.ClientSession(timeout=self.timeout)
self._session = self._create_session()
self._owned_session = True

async def sign_in(
Expand Down Expand Up @@ -740,8 +754,11 @@ async def refresh_access_token(refresh_token: str) -> AuthTokens:
url = f"{API_BASE_URL}{REFRESH_ENDPOINT}"
payload = {"refreshToken": refresh_token}

# Use ThreadedResolver for reliable DNS in containerized environments
resolver = aiohttp.ThreadedResolver()
connector = aiohttp.TCPConnector(resolver=resolver)
async with (
aiohttp.ClientSession() as session,
aiohttp.ClientSession(connector=connector) as session,
session.post(url, json=payload) as response,
):
response_data = await response.json()
Expand Down
Loading