Skip to content

Replace magic number with DhwOperationSetting.VACATION enum #48

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Copilot wants to merge 2 commits into from
Closed

Replace magic number with DhwOperationSetting.VACATION enum #48

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
728ce99
Initial plan
Copilot Dec 17, 2025
db24423
Replace magic number 5 with DhwOperationSetting.VACATION enum
Copilot Dec 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions src/nwp500/mqtt_device_control.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@
from typing import Any, Callable, Optional

from .constants import CommandCode
from .enums import DhwOperationSetting
from .exceptions import ParameterValidationError, RangeValidationError
from .models import Device, fahrenheit_to_half_celsius

Expand Down Expand Up @@ -196,7 +197,8 @@ async def set_dhw_mode(
device: Device object
mode_id: Mode ID (1=Heat Pump Only, 2=Electric Only, 3=Energy Saver,
4=High Demand, 5=Vacation)
vacation_days: Number of vacation days (required when mode_id == 5)
vacation_days: Number of vacation days (required when
mode_id == DhwOperationSetting.VACATION)

Returns:
Publish packet ID
Expand All @@ -214,7 +216,7 @@ async def set_dhw_mode(
- 4: High Demand (maximum heating capacity)
- 5: Vacation Mode (requires vacation_days parameter)
"""
if mode_id == 5: # Vacation mode
if mode_id == DhwOperationSetting.VACATION:
if vacation_days is None:
raise ParameterValidationError(
"Vacation mode requires vacation_days (1-30)",
Expand All @@ -232,7 +234,8 @@ async def set_dhw_mode(
else:
if vacation_days is not None:
raise ParameterValidationError(
"vacation_days is only valid for vacation mode (mode 5)",
f"vacation_days is only valid for vacation mode "
f"(mode {DhwOperationSetting.VACATION})",
parameter="vacation_days",
)
param = [mode_id]
Expand Down