Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates the operation mode handling to distinguish between commanded modes (used when controlling the device) and observed status modes (received from device status messages). The changes are based on network traffic analysis that revealed different operation mode values in status responses.
Key changes:
- Expands the
OperationModeenum to include both commanded modes (0-5) and observed status modes (32, 64, 96) - Adds aliases for common operation modes (
OFFandAWAY) - Documents the mapping between commanded and observed operation modes in the technical documentation
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/nwp500/models.py | Expands OperationMode enum with observed status modes and aliases |
| docs/DEVICE_STATUS_FIELDS.rst | Documents the mapping between commanded and observed operation modes |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.