Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds power on/off functionality to the CLI and library, enabling users to control device power state via command line and programmatically. The key enhancement is adding the POWER_OFF mode (value 6) to distinguish between powered-off devices and devices that are simply idle.
- Added
--power-onand--power-offCLI arguments for device power control - Enhanced OperationMode enum with POWER_OFF (6) state that appears in dhwOperationSetting
- Improved documentation to clarify distinction between operationMode (current state) and dhwOperationSetting (configured preference)
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/nwp500/models.py | Added POWER_OFF enum value and conversion logic for dhwOperationSetting field |
| src/nwp500/cli.py | Added power control CLI arguments and handler function |
| examples/power_control_example.py | New example demonstrating programmatic power control |
| docs/MQTT_MESSAGES.rst | Updated documentation to clarify operationMode vs dhwOperationSetting |
| docs/MQTT_CLIENT.rst | Enhanced mode documentation with clearer field relationships |
| docs/DEVICE_STATUS_FIELDS.rst | Comprehensive documentation on operation mode field distinctions |
| README.rst | Added CLI power control examples and corrected mode ID mappings |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.