Open
Conversation
Owner
|
Thanks for the PR, I understand the use case it is trying to address and believe it's doable. Unfortunately the patch as it stands cannot be practically merged, as most of the changes are editorial and would create inconsistencies with the coding style. |
Author
|
Sorry, I applied my code formatter to your files because they were unreadable in my editor. There appears to be a mixture of tabs and spaces in your project. I've reverted them, but I'd consider using something like prettier across your project. You can configure it to match your code style. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Allows access to local files via file://