Enable Glint by default for both JS and TS apps#273
Conversation
Implements RFC #976 (emberjs/rfcs#976): install and configure Glint v2 in blueprint output regardless of --typescript. JS apps get IDE tooling via jsconfig.json + the TypeScript Server plugin; TS apps get the full template type-check via the ember-tsc CLI. - Move @glint/ember-tsc, @glint/template, @glint/tsserver-plugin, @ember/app-tsconfig, and typescript out of the <% if (typescript) %> blocks in package.json so they install for both paths. - Add files/jsconfig.json for the JS path (extends @ember/app-tsconfig, noEmit:true). Filter it out for TS apps in index.js. - Stop excluding tsconfig.json's `types/` directory for JS apps — types/ is referenced by both jsconfig.json and tsconfig.json. The lint:types script remains TS-only (ember-tsc --noEmit). JS apps opt into editor tooling without a CLI type-check workflow. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
mansona
left a comment
There was a problem hiding this comment.
why are we doing this? 🤔 recent discussions in the tooling team meetings suggested that it was a good idea to make glint work out of the box without needing any typescript or jsconfig stuff, and thankfully that has all been done upstream 🎉
is there a real reason why you think that we should make this change? or is it just following what the original RFC said? if it's the latter then that might prompt a potential update to the RFC saying that we intend to make it work out of the box (in things like VS code) without any code changes in apps or blueprints. What do you think?
|
since we figured out how to get glint in the ember extension pack and working on js projects, I don't think we need this 🎉 thanks for helping us explore this! |
Summary
Implements RFC #976: Enable Glint by Default for the app blueprint. Glint v2 is now installed and configured for both TS and JS apps.
The blueprint already shipped Glint v2 packages — this PR moves them out of the `<% if (typescript) %>` blocks so JS apps benefit from editor tooling out of the box.
Related
Test plan
Note on archived predecessor
The earlier `embroider-build/app-blueprint` is archived; this PR is the same set of changes adapted for the new structure here.
🤖 Generated with Claude Code