Add a blog post about template tag going to recommended#1377
Add a blog post about template tag going to recommended#1377kategengler wants to merge 3 commits into
Conversation
✅ Deploy Preview for ember-blog ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
@mansona what do we need to update to get GJS syntax highlighting on the blog? |
kategengler
force-pushed
the
template-tag-recommended
branch
from
ce085df to
b8c5b2c
Compare
| Several commonly used helpers are now (as of v7.1.0) built-in as keywords in | ||
| when used within `<template>`: | ||
|
|
||
| - [`on` modifier]() |
There was a problem hiding this comment.
These need to be filled in, still?
There was a problem hiding this comment.
Yes, per the comment on why it is draft -- I need the 7.1 api docs to release first. Some of them can probably be found and linked before then but some are new and I'd rather do it at once.
Suggested fixes which should do the trick |
Co-authored-by: Ignace Maes <10243652+IgnaceMaes@users.noreply.github.com>
No dice. I confirmed the deploy preview redeployed after the suggested changes and checked in incognito, but there is no highlighting. I had tried plain ```gjs fences locally running the project yesterday and they also did not highlight. (which makes sense because the {data- bit is just extra info). |
Hmm looks like something went wrong in your latest commit, it removed the fences? |
Looks like GitHub cannot handle code suggestions with fences in them. That worked, thank you for noticing that 🎉 |
3 participants
Draft until after 7.1 API docs + need to link docs