Skip to content

Fix unsupported inline route template examples#28

Merged
NullVoxPopuli merged 1 commit into
ember-tooling:mainfrom
miguelcobain:fix-route-template-examples
Apr 16, 2026
Merged

Fix unsupported inline route template examples#28
NullVoxPopuli merged 1 commit into
ember-tooling:mainfrom
miguelcobain:fix-route-template-examples

Conversation

@miguelcobain

Copy link
Copy Markdown

Updates Ember route examples to stop using inline <template> blocks inside Route classes imported from @ember/routing/route, which is not supported.

  • Rewrites affected route examples to use:
    • app/routes/*.js for route logic
    • app/templates/*.gjs for templates
  • Updates the route template guidance to recommend separate route and template files
  • Extends the build/parser tooling so a single example can preserve multiple fenced code blocks
  • Regenerates derived artifacts:
    • skills/ember-best-practices/AGENTS.md
    • packages/ember-best-practices-build/test-cases.json
    • skills/ember-best-practices.zip

@NullVoxPopuli NullVoxPopuli merged commit bd3a165 into ember-tooling:main Apr 16, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants