fix(security): 2 improvements across 2 files#2772
Open
tomaioo wants to merge 2 commits into
Open
Conversation
- Security: Prototype Pollution in BaseObject class - Security: Potential Cross-Site Scripting (XSS) via htmlSafe in build-style helper Signed-off-by: tomaioo <203048277+tomaioo@users.noreply.github.com>
- Security: Prototype Pollution in BaseObject class - Security: Potential Cross-Site Scripting (XSS) via htmlSafe in build-style helper Signed-off-by: tomaioo <203048277+tomaioo@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
fix(security): 2 improvements across 2 files
Problem
Severity:
High| File:packages/ember-debug/utils/base-object.js:L4The
BaseObjectclass usesObject.assign(this, data || {})in its constructor, which can lead to prototype pollution if an attacker provides a specially crafted object with__proto__,constructor, orprototypekeys. This could allow modification of the Object prototype, leading to arbitrary code execution or other security issues. Additionally, thereopenmethod has the same vulnerability.Solution
Use a safe assignment method that only copies own properties and skips prototype-related keys. Consider using
Object.assignwith a null prototype object or explicitly filtering out dangerous keys like__proto__,constructor, andprototype.Changes
packages/ember-debug/utils/base-object.js(modified)packages/ember-inspector/app/helpers/build-style.js(modified)