Update template-compiler-test for v7 ESM-only build#21260
Merged
NullVoxPopuli merged 1 commit intoemberjs:nvp/v7-testfrom Mar 28, 2026
Merged
Conversation
The legacy CJS bundle at `dist/ember-template-compiler.js` was removed in v7. The ESM template compiler uses `minimal.ts` as its entry which exports `precompile` and `_buildCompileOptions` but not `_Ember`. Update the test to use ESM imports and verify the exports that actually exist in v7. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
dist/ember-template-compiler.jswas removed in v7 (thetemplateCompilerConfig()rollup entry was deleted)minimal.tsas its entry, which exportsprecompileand_buildCompileOptionsbut not_Ember,compile,VERSION, etc.template-compiler-test.jsto use ESM imports fromember-source/ember-template-compiler/index.js(matching the pattern used by the other converted node tests)Fixes the 6 node smoke test failures in #21240.
Test plan
node-node-testsscenario)🤖 Generated with Claude Code