Skip to content

Perf: Defer widget-schema prefetch AJAX to requestIdleCallback #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
collinversluis wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Perf: Defer widget-schema prefetch AJAX to requestIdleCallback #3

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 25 additions & 8 deletions assets/dev/js/editor/editor-base.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1137,15 +1137,16 @@ export default class EditorBase extends Marionette.Application {
}

requestWidgetsConfig() {
const excludeWidgets = {};
const run = () => {
const excludeWidgets = {};

jQuery.each( this.widgetsCache, ( widgetName, widgetConfig ) => {
if ( widgetConfig.controls ) {
excludeWidgets[ widgetName ] = true;
}
} );
jQuery.each( this.widgetsCache, ( widgetName, widgetConfig ) => {
if ( widgetConfig.controls ) {
excludeWidgets[ widgetName ] = true;
}
} );

elementorCommon.ajax.addRequest( 'get_widgets_config', {
elementorCommon.ajax.addRequest( 'get_widgets_config', {
data: {
exclude: excludeWidgets,
},
Expand All @@ -1166,7 +1167,23 @@ export default class EditorBase extends Marionette.Application {
} );
}
},
} );
} );
};

// Defer the schema-prefetch (request body + ~394 KB JSON response parse + the
// per-widget deep-merge in addWidgetsCache) into idle time so it does not race
// with the initial canvas render. The data is only needed when the user opens
// the widget panel to add a new element; in-page widgets already have their
// schemas in the boot config. Falls back to setTimeout where requestIdleCallback
// is unavailable (Safari pre-15.4).
const useDefer = elementorCommon?.config?.experimentalFeatures?.e_memoize_active_controls;
if ( useDefer && 'function' === typeof window.requestIdleCallback ) {
window.requestIdleCallback( run, { timeout: 3000 } );
} else if ( useDefer ) {
setTimeout( run, 0 );
} else {
run();
}
}

async refreshWidgets() {
Expand Down