Adds example 2 in chapter 50 of SFPE handbook.#59
Merged
JamieMaclean merged 24 commits intomainfrom Jan 16, 2026
Merged
Conversation
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds a working example for SFPE Handbook Chapter 50 Equation 50.14 (door opening force calculation). The example demonstrates unit conversion from imperial to SI units and follows fire engineering documentation patterns.
Changes:
- Created new example file for SFPE Handbook Chapter 50 with Example 2 showing door opening force calculations
- Updated the SFPE Handbook examples index page to include the new example and removed placeholder content
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| crates/python_api/docs/examples/sfpe-handbook/chapter-50.rst | Adds a complete example demonstrating door opening force calculation (Equation 50.14) with explicit unit conversions from imperial to SI |
| crates/python_api/docs/examples/sfpe-handbook-examples.rst | Updates the main SFPE Handbook examples page to include the new Chapter 50 example via include directive |
Contributor
Author
|
@JamieMaclean ready for review |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
JamieMaclean
approved these changes
Jan 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.