Stop reading dist/ember-template-compiler.js from ember-source#2691
Closed
NullVoxPopuli-ai-agent wants to merge 1 commit intoembroider-build:stablefrom
Closed
Conversation
ember-source v7 no longer ships `dist/ember-template-compiler.js` as a flat file. The template compiler is now at `dist/packages/ember-template-compiler/index.js` and is consumed via package exports, not via `app.import`. Make the vendor `ember-template-compiler.js` an empty stub, matching how `ember.js` and `ember-testing.js` are already handled.
Collaborator
|
bad bot, this is a breaking change |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ember-source v7 no longer ships
dist/ember-template-compiler.jsas a flat file. The template compiler now lives atdist/packages/ember-template-compiler/index.jsand is consumed via package exports, notapp.import.The
combinedVendormethod currently does areadFileSyncon this removed file, crashing the build. This PR makes the vendorember-template-compiler.jsan empty stub, matching howember.jsandember-testing.jsare already handled on lines 362-363.app.import('vendor/ember/ember-template-compiler.js')is no longer a supported pattern — the template compiler is discovered automatically bybabel-plugin-ember-template-compilationvia ember-source's package.json exports.Context
🤖 Generated with Claude Code