Conversation
55d1543 to
48c2abc
Compare
This comment was marked as resolved.
This comment was marked as resolved.
48c2abc to
7ac6666
Compare
7ac6666 to
c35e080
Compare
|
Hey @dasmy. This PR is basically ready for merge but since you also raised that same request, I wanted to hear your thoughts on whether it aligns with your expectations. Anything missing? Regarding the idea to generalize this to all classes --> we can follow up on this in a separate PR. This one here is just to provide the basic skeleton and necessary machinery for serialization so that @tobiasploetz can continue integrating the LLM recommender. But feel free to share any thoughts that come to your mind 🧠 |
|
Thanks for setting this up. This is exactly what I had in mind for #580 . |
|
Alright, waiting for @Scienfitz's opinion and then we can merge. One thing to discuss: as mentioned in one of the comments, I see the current |
a88c3ed to
bc1bcc2
Compare
AVHopp
left a comment
There was a problem hiding this comment.
LGTM, thanks for the work :)
…throughout the codebase
…s; ensure metadata is never None and add is_empty property to Metadata classes
Co-authored-by: Martin Fitzner <17951239+Scienfitz@users.noreply.github.com>
d6f2cb4 to
f3d758d
Compare
d76b450 to
157d251
Compare
|
|
||
| # Folders that are temporarily created when building the documentation | ||
| docs/_autosummary | ||
| docs/_build |
There was a problem hiding this comment.
@AdrianSosic could you please add ".env" as another exception as well? Did some cleaning and setup of my local IDE and that would be super helpful :)
We can ensure this through static type checking and our converters, no unit tests needed
Roundtrip consistency is already tested in the serialization test module
The cases are already covered by the integration and converter tests
2e216e1 to
e7e4134
Compare
Has been migrated from Github to ReadTheDocs
ecad868 to
f3760d9
Compare
Summary
This PR implements a flexible metadata system for annotating BayBE objects with a description, unit, and other information. So far integrated into
Parameteronly.Usage Example