Conversation
Hrovatin
requested review from
AVHopp,
AdrianSosic and
Scienfitz
as code owners
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
Hrovatin
force-pushed
the
docs/easy_access
branch
from
aa1cbcb to
e963d6b
Compare
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
Hrovatin
force-pushed
the
docs/easy_access
branch
from
9efc271 to
297aedc
Compare
|
@Scienfitz done, built docs here: https://hrovatin.github.io/baybe/latest/ |
AVHopp
left a comment
AVHopp
left a comment
There was a problem hiding this comment.
Only one very minor thing, but other than that I'd say merge 🚀
There was a problem hiding this comment.
why has this figure been touched? optimize or something?
(we'll have to redo all figures once we release new priors in the next release anyway)
There was a problem hiding this comment.
It seems it was missed from the miniPR https://github.com/emdgroup/baybe/pull/726/changes
I can make one more miniPR with that image specifically @Scienfitz
What I changed is that it switches automatically based on browser defaults - before it was anyway static lightmode, so even if this does not work with website toggle, it is still better than before.
Ideal in future you could make it colored so that it works on light/dark without switch
README.md
Outdated
|
|
||
| BayBE provides a **general-purpose toolbox** for Bayesian Design of Experiments, | ||
| focusing on making this procedure easily accessible for real-world experiments. | ||
| Its utility was already shown in a variety of real-world experimental campaigns in both industry and academia. |
There was a problem hiding this comment.
opportunity to link to the Citation section?
There was a problem hiding this comment.
Added, but I think we cite only our own paper there. Is that what you had in mind?
|
|
||
| <div align="center"> | ||
|
|
||
|  |
There was a problem hiding this comment.
the sue of grey seems strange in white mode, but I guess it was done to not have to make several bright/dark mode variants, is that right?
There was a problem hiding this comment.
Yes, since we couldn't find an option that works on both github (browser based) and website toggle
| <li>Conduct AB testing via <a href="https://emdgroup.github.io/baybe/stable/examples/Multi_Armed_Bandit/Multi_Armed_Bandit.html">bandit models</a>.</li> | ||
| </ul> | ||
| </li> | ||
| <li>Define the optimal target value via <a href="https://emdgroup.github.io/baybe/stable/userguide/transformations.html">target transformations</a>.</li> |
There was a problem hiding this comment.
define the optimal target value sounds strange to me, can we come up with a better wording?
There was a problem hiding this comment.
What about Specify what a “good” target value is
This PR tackles some points from #598, focused on #598 (comment) as agreed on the team meeting
Link to the built documentation
I still have issues with displaying images, will investigate this.