Multi fidelity acquisition functions and recommender logic#756
Multi fidelity acquisition functions and recommender logic#756
Conversation
AdrianSosic
force-pushed
the
dev-mfbo-main-acquisition-functions
branch
from
59af949 to
dd2974f
Compare
|
Hey @jpenn2023, the branch now sits on top of the current surrogate one, so you should also have an up-to-date view now (including the commits from the surrogate) |
jpenn2023
requested review from
AVHopp,
AdrianSosic and
Scienfitz
as code owners
|
|
||
| # Jordan MHS NOTE: typing awkward here since register_buffer does not declare attr. | ||
| fidelity_columns: Tensor | ||
| fidelities_comb: Tensor |
There was a problem hiding this comment.
what does comb refer to?
There was a problem hiding this comment.
Combinations. The acqf allows for multiple fidelity columns. The multi-parameter fidelity value is then an outer product over the single-parameter fidelities, with an assumption that the costs and zetas add between fidelity parameters. Will change variable name to fidelity_combinations for now.
| r"""Second optimisation stage: choose optimal fidelity to query.""" | ||
| # Jordan MHS NOTE: casting here because botorch model likelihood is too | ||
| # broadly typed. Check best practice in case likelihood does not have noise. | ||
| likelihood = cast(GaussianLikelihood, self.model.likelihood) |
There was a problem hiding this comment.
assert instead of cast OR add workaround to set noise to 0 if not present in class (preference as discussed)
baybe/acquisition/_builder.py
Outdated
|
|
||
| self._args.current_value = current_value | ||
|
|
||
| def _set_project(self) -> None: |
There was a problem hiding this comment.
confusing name, why not set_projection?
baybe/acquisition/_builder.py
Outdated
|
|
||
| curr_val_acqf = FixedFeatureAcquisitionFunction( | ||
| acq_function=PosteriorMean(self._botorch_surrogate), | ||
| d=7, |
There was a problem hiding this comment.
hardcoded to 7? seems strange
There was a problem hiding this comment.
Good catch! This is a typo carried over from the Hartmann7 example.
baybe/acquisition/utils.py
Outdated
| """Construct column indices and values of costs, fidelities and values for MFUCB.""" | ||
| fidelity_params = { | ||
| p | ||
| for i, p in enumerate(searchspace.parameters) |
There was a problem hiding this comment.
i is never used in this comprerehnsion and thus enumerate seems obsolete?
3 participants
No description provided.