Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the project’s settings initialization to take advantage of a newer attrs release, removing a previous workaround around Attribute.alias handling and simplifying the default-factory logic used for environment-driven settings.
Changes:
- Bump runtime dependency on
attrsto>=26.1.0(and update lockfile accordingly). - Refactor the per-field default factory builder into a module-level helper and remove the prior
aliasfallback workaround. - Align deprecation messaging / env-var translation to use
fld.aliasdirectly.
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
uv.lock |
Locks attrs to 26.1.0 and updates the dev metadata constraint accordingly. |
pyproject.toml |
Raises the minimum supported attrs version to >=26.1.0. |
baybe/settings.py |
Moves the default-factory builder to global scope and relies on Attribute.alias directly for env var naming and deprecation guidance. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Scienfitz
approved these changes
Mar 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Applies two minor changes:
attrsto latest release, which allows to undo thealiasworkaround