fix: stop recursing into re-exports of external packages#27
Conversation
Version AnalysisNext Version: Changelog: 📄 View detailed changelog in job summary Badge: |
There was a problem hiding this comment.
Pull request overview
This PR updates the Dart doc generator’s recursive export traversal to stop following external packages’ own re-export chains, preventing large transitive dependency graphs (e.g., Flutter/vector_math) from being pulled into generated API docs.
Changes:
- Track whether the currently visited library belongs to the host package (
isHostPackage). - Only recurse into
exportedLibraries2when visiting host-package libraries, not external dependencies.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Version AnalysisNext Version: Changelog: 📄 View detailed changelog in job summary Badge: |
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Version AnalysisNext Version: Changelog: 📄 View detailed changelog in job summary Badge: |
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated 3 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Version AnalysisNext Version: Changelog: 📄 View detailed changelog in job summary Badge: |
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Version AnalysisNext Version: Changelog: 📄 View detailed changelog in job summary Badge: |
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
When a host package re-exports symbols from a dependency (e.g.
patrol), the doc generator was recursively following that dependency's own export chain too — pulling in the entire Flutter/vector_math transitive graph. This adds anisHostPackagecheck so re-export traversal stops at the package boundary: external libraries are still visited (their symbols are part of the public API), but their own exports are not followed.