feat!: Add exception to onVerificationFailed callback, improve error handling, add API Guard to CI by flxapps · Pull Request #20 · emdgroup/mtrust-sec-kit

flxapps · 2025-10-07T09:45:30Z

This PR enhances error handling by adding an optional SecReaderException parameter to the onVerificationFailed callback in SecWidget and SecModalBuilder. This provides developers with detailed information about why a verification process failed, enabling more specific error handling.

Changes include:

Updated the onVerificationFailed callback signature across SecWidget, SecModalBuilder, the example app, and tests.
Propagated the SecReaderException from the underlying logic to the UI layer.
Updated the README.md to document the new callback parameter and explain its usage.
Add M-Trust API Guard to CI
Refactor error handling

Breaking Changes

⚠️ This is a breaking change

All consumers must update their onVerificationFailed callback:

Before:

onVerificationFailed: () {
  print('Identification failed');
}

After:

onVerificationFailed: (exception) {
  print('Verification failed: ${exception.message}');
}

Copilot

Pull Request Overview

Adds propagation of SecReaderException to onVerificationFailed callbacks to improve error diagnostics and handling across SecWidget and SecModalBuilder.

Passes exception details from lower layers to UI callbacks.
Introduces SecResultFailed.exception and updates example, README, and tests to new signatures.

Reviewed Changes

Copilot reviewed 6 out of 7 changed files in this pull request and generated 6 comments.

Show a summary per file

File	Description
lib/src/ui/sec_widget.dart	Adds exception-typed onVerificationFailed and forwards exception; updates button handler and child callback wiring.
lib/src/ui/sec_modal.dart	Makes onVerificationFailed accept exception; adds SecResultFailed(exception) and forwards it through modal result.
lib/src/ui/scanning_view.dart	Forwards underlying exception to onVerificationFailed; updates button handler.
test/sec_widget_test.dart	Adjusts tests to new callback arity.
example/lib/main.dart	Updates example to log received exception; minor import reorder.
README.md	Documents the new exception parameter for onVerificationFailed.

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

lib/src/ui/sec_widget.dart

lib/src/ui/scanning_view.dart

lib/src/ui/sec_widget.dart

lib/src/ui/sec_modal.dart

lib/src/ui/sec_widget.dart

ElectricCookie

Please add a test using virtual strategy to simulate the error being thrown and correctly passed back to the widget

Copilot

Pull request overview

Copilot reviewed 10 out of 47 changed files in this pull request and generated 4 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

lib/src/ui/scanning_view.dart

lib/src/sec_reader_exception.dart

test/sec_widget_test.dart

lib/src/ui/sec_widget.dart

Copilot

Pull request overview

Copilot reviewed 10 out of 47 changed files in this pull request and generated no new comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot

Pull request overview

Copilot reviewed 15 out of 52 changed files in this pull request and generated 3 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

lib/src/ui/sec_widget.dart

lib/src/sec_reader_exception.dart

analysis_options.yaml

Copilot

Pull request overview

Copilot reviewed 16 out of 55 changed files in this pull request and generated no new comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

…xception

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Previously, non-DeviceError exceptions were swallowed and null was returned, hiding failures from callers. Now all unexpected exceptions propagate. Return type changed to non-nullable UrpSecPrimeResponse since all code paths now either return a value or throw.

DeviceErrors that propagate through SECReader are now caught by _SecExceptionMapper, producing a user-friendly LdException with retry support. This keeps SECReader transparent while ensuring the widget UI handles all error types consistently.

…SECReader

…n build and pull request processes

…ons.yaml

github-actions · 2026-02-23T12:06:01Z

Version Analysis

Next Version: 3.0.0-dev.1

Changelog: 📄 View detailed changelog in job summary

Copilot

Pull request overview

Copilot reviewed 16 out of 54 changed files in this pull request and generated no new comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

github-actions · 2026-02-23T13:48:47Z

Version Analysis

Next Version: 3.0.0-dev.1

Changelog: 📄 View detailed changelog in job summary

github-actions · 2026-02-23T14:11:28Z

Version Analysis

Next Version: 3.0.0-4

Changelog: 📄 View detailed changelog in job summary

Badge:

.github/workflows/build_dev.yaml

…files

github-actions · 2026-02-23T14:47:19Z

Version Analysis

Next Version: 3.0.0-4

Changelog: 📄 View detailed changelog in job summary

Badge:

Copilot

Pull request overview

Copilot reviewed 16 out of 54 changed files in this pull request and generated no new comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

ElectricCookie · 2026-02-23T14:49:51Z

LGTM requesting Review from Josh too to make sure he's in the loop

JoshuaWell

LGTM as well :)

flxapps self-assigned this Oct 7, 2025

flxapps changed the base branch from main to dev October 7, 2025 10:41

flxapps force-pushed the feat/add-exception-to-verification-failed-callback branch from 06d5ee3 to 58df0c4 Compare October 7, 2025 11:03

Copilot AI review requested due to automatic review settings October 7, 2025 11:03

Copilot AI reviewed Oct 7, 2025

View reviewed changes

flxapps force-pushed the feat/add-exception-to-verification-failed-callback branch from 1975d58 to e562c72 Compare October 7, 2025 11:43

flxapps requested a review from ElectricCookie October 7, 2025 12:34

flxapps changed the title ~~feat: Add exception to onVerificationFailed callback~~ feat!: Add exception to onVerificationFailed callback Oct 8, 2025

ElectricCookie requested changes Feb 5, 2026

View reviewed changes

flxapps requested a review from ElectricCookie February 5, 2026 13:01

flxapps requested a review from Copilot February 12, 2026 16:06

Copilot started reviewing on behalf of flxapps February 12, 2026 16:07 View session

Copilot AI reviewed Feb 12, 2026

View reviewed changes

lib/src/ui/scanning_view.dart Show resolved Hide resolved

lib/src/sec_reader_exception.dart Outdated Show resolved Hide resolved

test/sec_widget_test.dart Outdated Show resolved Hide resolved

lib/src/ui/sec_widget.dart Outdated Show resolved Hide resolved

flxapps requested a review from Copilot February 13, 2026 13:47

Copilot started reviewing on behalf of flxapps February 13, 2026 13:47 View session

Copilot AI reviewed Feb 13, 2026

View reviewed changes

flxapps requested a review from Copilot February 16, 2026 10:22

Copilot started reviewing on behalf of flxapps February 16, 2026 10:22 View session

flxapps changed the title ~~feat!: Add exception to onVerificationFailed callback~~ feat!: Add exception to onVerificationFailed callback, improve error handling, add API Guard to CI Feb 16, 2026

Copilot AI reviewed Feb 16, 2026

View reviewed changes

lib/src/ui/sec_widget.dart Show resolved Hide resolved

lib/src/sec_reader_exception.dart Outdated Show resolved Hide resolved

analysis_options.yaml Outdated Show resolved Hide resolved

flxapps force-pushed the feat/add-exception-to-verification-failed-callback branch from aee99ff to fe39270 Compare February 16, 2026 11:58

flxapps requested a review from Copilot February 16, 2026 12:32

Copilot started reviewing on behalf of flxapps February 16, 2026 12:32 View session

Copilot AI reviewed Feb 16, 2026

View reviewed changes

flxapps force-pushed the feat/add-exception-to-verification-failed-callback branch 2 times, most recently from b7f695c to c5dc7c8 Compare February 16, 2026 14:00

flxapps and others added 4 commits February 16, 2026 15:28

feat: enrich verification failure callback with exception details

ea8d7fa

refactor: provide safe casting for exceptions

2ef47a6

rerfactor: update onVerificationFailed to require non-null SecReaderE…

99b3046

…xception

docs: update doc comment for onVerificationFailed method

56e668c

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

flxapps added 10 commits February 16, 2026 15:28

refactor: add exception types for connection and command failures in …

31423fe

…SECReader

docs: enhance documentation regarding exception handling

b600d42

ci: add mtrust-api-guard job to workflows for enhanced verification i…

d99c6a6

…n build and pull request processes

chore: add .vscode/settings.json to .gitignore

1ea1ebd

ci: initial commit for api-guard-generated files

3ffcb3f

docs: update documentation while resolving linter issues

50be5f7

chore: add api_guard exclusion for example directory in analysis_opti…

5d1da86

…ons.yaml

chore: add pre_release parameter to api-guard job in PR workflow

ab1263f

flxapps force-pushed the feat/add-exception-to-verification-failed-callback branch from 9db24ea to ab1263f Compare February 16, 2026 14:29

flxapps requested a review from Copilot February 23, 2026 12:19

Copilot started reviewing on behalf of flxapps February 23, 2026 12:19 View session

Copilot AI reviewed Feb 23, 2026

View reviewed changes

ElectricCookie requested changes Feb 23, 2026

View reviewed changes

.github/workflows/build_dev.yaml Outdated Show resolved Hide resolved

chore: remove condition to skip api-guard for dependabot in workflow …

3ac6be8

…files

flxapps requested a review from Copilot February 23, 2026 14:45

Copilot started reviewing on behalf of flxapps February 23, 2026 14:45 View session

flxapps requested a review from ElectricCookie February 23, 2026 14:46

ElectricCookie approved these changes Feb 23, 2026

View reviewed changes

ElectricCookie requested a review from JoshuaWell February 23, 2026 14:49

Copilot AI reviewed Feb 23, 2026

View reviewed changes

JoshuaWell approved these changes Feb 24, 2026

View reviewed changes

flxapps merged commit 422d320 into dev Feb 28, 2026
9 checks passed

flxapps deleted the feat/add-exception-to-verification-failed-callback branch February 28, 2026 10:51

Conversation

flxapps commented Oct 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Breaking Changes

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ElectricCookie left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

github-actions bot commented Feb 23, 2026

Version Analysis

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

github-actions bot commented Feb 23, 2026

Version Analysis

Uh oh!

github-actions bot commented Feb 23, 2026

Version Analysis

Uh oh!

Uh oh!

github-actions bot commented Feb 23, 2026

Version Analysis

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

ElectricCookie commented Feb 23, 2026

Uh oh!

JoshuaWell left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

flxapps commented Oct 7, 2025 •

edited

Loading