Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the build workflows to stop using secrets: inherit for the api-guard reusable workflow call and instead pass an explicit elevated token.
Changes:
- Replaced
secrets: inheritwith an explicitsecrets.token: ${{ secrets.ELEVATED_TOKEN }}mapping in the main build workflow. - Replaced
secrets: inheritwith an explicitsecrets.token: ${{ secrets.ELEVATED_TOKEN }}mapping in the dev build workflow.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| .github/workflows/build_main.yaml | Updates secrets passing for the api-guard reusable workflow call (currently with incorrect indentation). |
| .github/workflows/build_dev.yaml | Updates secrets passing for the api-guard reusable workflow call (currently with incorrect indentation). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
Version AnalysisNext Version: Changelog: 📄 View detailed changelog in job summary Badge: |
…crets for build workflows
flxapps
force-pushed
the
ci/use-elevated-token-for-api-guard
branch
from
e148b88 to
bfd49ce
Compare
There was a problem hiding this comment.
Pull request overview
This PR adjusts the build workflows’ reusable api-guard job to pass an explicit elevated token secret rather than inheriting all caller secrets, aligning with the API Guard workflow’s expected secret name.
Changes:
- Replace
secrets: inheritwith an explicitsecrets.token: ${{ secrets.ELEVATED_TOKEN }}mapping for theapi-guardjob in main builds. - Apply the same explicit secret mapping for the
api-guardjob in dev builds.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| .github/workflows/build_main.yaml | Passes ELEVATED_TOKEN explicitly to the reusable API Guard publish workflow as token. |
| .github/workflows/build_dev.yaml | Passes ELEVATED_TOKEN explicitly to the reusable API Guard publish workflow as token. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
Version AnalysisNext Version: Changelog: 📄 View detailed changelog in job summary Badge: |
Replaces 'inherit' with explicit token declaration in api-guard secrets for build workflows.