Prefer fetch by id when available in update and delete fonctions.#2
Open
sulphur wants to merge 3 commits intoemedia-project:masterfrom
Open
Prefer fetch by id when available in update and delete fonctions.#2sulphur wants to merge 3 commits intoemedia-project:masterfrom
sulphur wants to merge 3 commits intoemedia-project:masterfrom
Conversation
in where clause. It fix the bug when updating rows in tables with float columns.
sulphur
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, texas update function generates an update clause that puts un WHERE all values from the row. In the case where there are float values because of floating precision, the float stored in DB might not correspond to one that was fetched example difference is like 0.000000000001 it is enough though to make an update (or delete) fail.