Rename max_retries to max_attempts for semantic clarity#2
Merged
emilioSp merged 5 commits intofeat/retry-logicfrom Jan 28, 2026
Merged
Rename max_retries to max_attempts for semantic clarity#2emilioSp merged 5 commits intofeat/retry-logicfrom
emilioSp merged 5 commits intofeat/retry-logicfrom
Conversation
Co-authored-by: emilioSp <22614105+emilioSp@users.noreply.github.com>
Co-authored-by: emilioSp <22614105+emilioSp@users.noreply.github.com>
Co-authored-by: emilioSp <22614105+emilioSp@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Update retry logic implementation based on review comments
Rename max_retries to max_attempts for semantic clarity
Jan 28, 2026
emilioSp
approved these changes
Jan 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The retry logic used
max_retrieswith semantics that made it behave as a max attempts threshold (1 initial + N-1 retries), causing confusion about whether it meant "total attempts" or "retries after first attempt".Changes:
max_retries→max_attemptsin types, consumer logic, and migrationretry_counttracks failures, not attempt numbersALTER TYPE ... REMOVE VALUEsyntax (PostgreSQL doesn't support enum value removal)Semantics:
The naming now correctly reflects that this value controls total execution attempts, not retry-after-failure count.
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.