Skip to content

Minor improvements related to builder for tkdantic #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
emin63 merged 4 commits into from
Mar 5, 2026
Merged

Minor improvements related to builder for tkdantic #19

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
39cbfa1
if no params, just run callback
emin63 Mar 5, 2026
c59d664
provide parent=self when doing callback with no args
emin63 Mar 5, 2026
b1636c0
Have parameters default to empty list.
emin63 Mar 5, 2026
ef8e005
bump version
emin63 Mar 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ox_ui/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,4 +2,4 @@
"""


VERSION = '0.3.10'
VERSION = '0.3.11'
7 changes: 5 additions & 2 deletions ox_ui/tkdantic/builder.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -902,8 +902,11 @@ def _build_command_buttons(self):
add_tooltip(btn, model_doc)

def _open_command(self, info):
"""Open a ModelCommandWindow for *info*."""
assert len(info.parameters) <= 1
"""Open ModelCommandWindow for *info* or just run it if on params."""
if not info.parameters:
return info.callback(parent=self)
if len(info.parameters) != 1:
raise ValueError(f'Cannot handle {info=} when parameters !=1.')
ModelCommandWindow(
self, command=info, url_var=self._url_var,
timeout_var=self._timeout_var, max_horizontal=4)
Expand Down
4 changes: 2 additions & 2 deletions ox_ui/tkdantic/command.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,15 +5,15 @@
from typing import Callable, List, Optional, Type
from typing_extensions import Self

from pydantic import BaseModel, model_validator
from pydantic import BaseModel, Field, model_validator


class Command(BaseModel):
"""Basic command object.
"""

title: str
parameters: List[Type[BaseModel]]
parameters: List[Type[BaseModel]] = Field(default_factory=list)
description: str
name: Optional[str] = None

Expand Down