Add e1000 driver (8254x Intel NiCs)#36
Open
jackiedinh8 wants to merge 3 commits into
Open
Conversation
added 2 commits
January 3, 2022 16:00
emmericp
reviewed
Jan 3, 2022
Owner
emmericp
left a comment
emmericp
left a comment
There was a problem hiding this comment.
Very cool, thank you!
I'll see if I can go find some real hardware to test this with :)
| } | ||
| if (vendor_id == 0x1af4 && device_id >= 0x1000) { | ||
| return virtio_init(pci_addr, rx_queues, tx_queues); | ||
| } else if (vendor_id == 0x8086 && device_id >= 0x1000) { |
Owner
There was a problem hiding this comment.
That won't work because it would also match all of the ixgbe NICs (Vendor 8086 is Intel) :/
And it's probably also not feasible to hard-code all the IDs here. Not sure if I have a good solution here beside maybe hard-coding some good device IDs? Include that pci database and do a string search? Meh.
Author
There was a problem hiding this comment.
Maybe each driver has a function like is_e1000(vendor_id, device_id) or is_ixgbe(vendor_id, device_id) to check whether it supports a NIC? If it supports, then proceed to init the driver.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.