pci: replace assert with error handling in enable_dma#38
Open
0xfka wants to merge 1 commit into
Open
Conversation
assert() calls abort() on failure, which leaks the file descriptor. It's also disabled with -DNDEBUG flag, causing failures to be silently ignored while I/O operations still execute. Resource: INTERNATIONAL STANDARD ©ISO/IEC ISO/IEC 9899:201x page 186-187, 7.2 Diagnostics <assert.h>" Signed-off-by: Fatih Karaoğlu <fatih39333@gmail.com>
Author
|
@emmericp I'm not sure this repository is maintained or not, but you may want to check. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
assert() calls abort() on failure, which leaks the file descriptor. It's also disabled with -DNDEBUG flag, causing failures to be silently ignored while I/O operations still execute. Resource: INTERNATIONAL STANDARD ©ISO/IEC ISO/IEC 9899:201x page 186-187, 7.2 Diagnostics <assert.h>".