partition: Improve bidi link down detection#20
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR improves partition/link detection by allowing classy_partition:bidi_link/3 to conclusively return {ok, false} in more “partial data” scenarios (e.g., when one node is missing from classy:info/1), and introduces a new unid_link/3 helper to query one-way connectivity.
Changes:
- Add
classy_partition:unid_link/3and afind_peer_by_nodeid/2helper to detect one-way link state from a single node’s peer view. - Enhance
classy_partition:bidi_link/3to return{ok, false}when either direction can be proven disconnected, even if one node is missing fromClusterInfo. - Update the Common Test suite to validate symmetric bidi/unid detection and the improved “node down” behavior.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| test/classy_SUITE.erl | Renames and expands the link-detection testcase to cover bidi + unid behavior, including node-down cases. |
| src/classy_partition.erl | Adds unid_link/3, refines bidi_link/3 fallback logic, and introduces peer lookup by node id. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
cbbed15 to
961d610
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.