Skip to content

partition: Improve bidi link down detection#20

Merged
ieQu1 merged 1 commit into
masterfrom
dev/bidi-link
Jun 17, 2026
Merged

partition: Improve bidi link down detection#20
ieQu1 merged 1 commit into
masterfrom
dev/bidi-link

Conversation

@ieQu1

@ieQu1 ieQu1 commented Jun 17, 2026

Copy link
Copy Markdown
Member

No description provided.

@ieQu1 ieQu1 marked this pull request as ready for review June 17, 2026 14:51
@ieQu1 ieQu1 requested a review from Copilot June 17, 2026 14:51

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR improves partition/link detection by allowing classy_partition:bidi_link/3 to conclusively return {ok, false} in more “partial data” scenarios (e.g., when one node is missing from classy:info/1), and introduces a new unid_link/3 helper to query one-way connectivity.

Changes:

  • Add classy_partition:unid_link/3 and a find_peer_by_nodeid/2 helper to detect one-way link state from a single node’s peer view.
  • Enhance classy_partition:bidi_link/3 to return {ok, false} when either direction can be proven disconnected, even if one node is missing from ClusterInfo.
  • Update the Common Test suite to validate symmetric bidi/unid detection and the improved “node down” behavior.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
test/classy_SUITE.erl Renames and expands the link-detection testcase to cover bidi + unid behavior, including node-down cases.
src/classy_partition.erl Adds unid_link/3, refines bidi_link/3 fallback logic, and introduces peer lookup by node id.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread src/classy_partition.erl Outdated
@ieQu1 ieQu1 force-pushed the dev/bidi-link branch 2 times, most recently from cbbed15 to 961d610 Compare June 17, 2026 14:56
@ieQu1 ieQu1 merged commit 7c857b1 into master Jun 17, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants