Reduce log spam#21
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR clarifies hook behavior by introducing named priority bounds for built-in hooks, adjusts a few tracepoint calls for consistency, and changes default site/cluster ID generation to use uppercase hex encoding.
Changes:
- Generate default site/cluster IDs as uppercase hex instead of base64.
- Add
?max_hook_prio/?min_hook_priomacros and use them for built-in hook registration priorities. - Simplify/standardize some
?tp(...)tracepoint invocations in membership sync paths.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
src/classy_node.erl |
Switches default persistent ID generation from base64 to uppercase hex. |
src/classy_membership.erl |
Updates several tracepoint calls to a 2-argument form and slightly reformats one trace call. |
src/classy_internal.hrl |
Introduces hook priority bound macros used by built-in hook registration. |
src/classy_hook.erl |
Uses the new hook priority macros for default/built-in hooks. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.