Merged
Conversation
- Tokens generated in the `Pause` time have ben consumed in this check. And this period should not be included in the next check. Or the `Pause` time will be used to recalculate as the token generation time. | <-------------- Tokens consumed ----------------> | | | | Last Now Pause To | <--- Time Diff ----> | <------- Pause ----------> |
zmstone
approved these changes
Sep 23, 2025
JimMoen
commented
Sep 23, 2025
| end; | ||
|
|
||
| consume(Name, Tokens) when is_integer(Tokens), Tokens > 0 -> | ||
| try ets:update_counter(?TAB, {tokens, Name}, {2, -Tokens, 0, 0}) of |
Member
Author
There was a problem hiding this comment.
the previous consume func would always try consume token even the bucket has already exhausted.
The remaining tokens can be negatived now. which means it borrowed tokens from future.
And the specific pause time will be returned based on the actual number of borrowed tokens and the generation rate.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Port #211 and #212 to master
(except appup)