Skip to content

fix: adapt to OTP 28 changes#214

Merged
id merged 1 commit intoemqx:masterfrom
id:20251009-adapt-to-otp28
Oct 10, 2025
Merged

fix: adapt to OTP 28 changes#214
id merged 1 commit intoemqx:masterfrom
id:20251009-adapt-to-otp28

Conversation

@id
Copy link
Copy Markdown
Contributor

@id id commented Oct 9, 2025

No description provided.

@id id force-pushed the 20251009-adapt-to-otp28 branch 2 times, most recently from cef0431 to 4513dd9 Compare October 9, 2025 18:56
@id id changed the title fix: replace ?'street-address' macro with OID fix: adapt to OTP 28 changes Oct 9, 2025
@id id force-pushed the 20251009-adapt-to-otp28 branch from 4513dd9 to a34625d Compare October 9, 2025 19:02
{?'id-domainComponent' , "DC"},
{?'id-emailAddress' , "EMAILADDRESS"},
{?'street-address' , "STREET"},
{{2,5,4,9} , "STREET"},
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just curiosity: the ?street-address macro was removed in 28?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks this way.

OTP 27

$ git grep street-address | grep -v SUITE
lib/public_key/asn1/OTP-PKIX.asn1:       street-address, StreetAddress,
lib/public_key/asn1/OTP-PKIX.asn1:           x400-street-address |
lib/public_key/asn1/OTP-PKIX.asn1:x400-street-address  EXTENSION-ATTRIBUTE-CLASS ::= {
lib/public_key/asn1/OTP-PKIX.asn1:                   ID street-address
lib/public_key/asn1/PKIX1Explicit88.asn1:street-address INTEGER ::= 17

OTP 28

$ git grep street-address | grep -v SUITE
$ 

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@id id merged commit 488de49 into emqx:master Oct 10, 2025
4 checks passed
@id id deleted the 20251009-adapt-to-otp28 branch October 10, 2025 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants