Skip to content

perf: faster vbi decode when strict-protocol-compliance is on. #87

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
qzhuyan merged 1 commit into from
Feb 11, 2026
Merged

perf: faster vbi decode when strict-protocol-compliance is on. #87

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions src/mqtt_serde/base_data.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,12 +95,11 @@ impl VariableByteInteger {
}

// MQTT 5.0 Protocol Compliance: Check for non-minimal VBI encoding
// Optimized check: A VBI is non-minimal if it has more than one byte and
// the last byte (where MSB=0) is zero (e.g., [0x80, 0x00]).
#[cfg(feature = "strict-protocol-compliance")]
{
// A VBI encoding is non-minimal if it could be represented with fewer bytes
// This happens when there are unnecessary continuation bytes
let minimal_encoded = VariableByteInteger::encode(value as u32);
if minimal_encoded.len() != i {
if i > 1 && buffer[i - 1] == 0 {
return Err(ParseError::ParseError(
"Variable Byte Integer encoding is not minimal".to_string(),
));
Expand Down