fix: handle large text binds in DML#9
Open
hjianbo wants to merge 1 commit into
Open
Conversation
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes Oracle DML execution when a text bind grows beyond 4000 characters.
The failure was reproduced from the EMQX Oracle action write path: an
INSERTinto anNCLOBpayload column works with a small payload, but a later payload larger than 4000 characters can fail when another bind expression follows the payload bind, for example a timestamp expression after thepayloadvalue.The issue is in the driver bind metadata/cursor handling, not in the caller. A cursor prepared for the small text bind shape can be reused for a later large text bind shape, and Oracle can reject the bind or close the connection.
Changes
CLOBvalues are sent last, and returnSQL%ROWCOUNTas normalaffected_rows.Side Effects
For the large-text/non-trailing-bind DML edge case, a batch may be executed internally row by row to avoid the Oracle protocol failure. The public result shape remains
{affected_rows, Total}for successful DML batches.Tests
rebar3 compilerebar3 ct --suite test/jamdb_oracle_SUITE.erl --group lob_datatypes