Skip to content

feat(autoheal): Add autoheal callback#210

Merged
ieQu1 merged 1 commit into
mainfrom
dev/on-heal-callback
May 12, 2026
Merged

feat(autoheal): Add autoheal callback#210
ieQu1 merged 1 commit into
mainfrom
dev/on-heal-callback

Conversation

@ieQu1
Copy link
Copy Markdown
Member

@ieQu1 ieQu1 commented May 12, 2026

No description provided.

thalesmg
thalesmg previously approved these changes May 12, 2026
Comment thread src/mria_autoheal.erl
Comment thread src/mria_autoheal.erl
reboot_minority(lists:append(Minorities)).
heal_partition([Majority|Minorities]) ->
Result = reboot_minority(lists:append(Minorities)),
mria_lib:exec_callback(heal_partition, {Majority, Minorities}),
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: add a comment to doc that the callback result is discarded.

Copy link
Copy Markdown
Member Author

@ieQu1 ieQu1 May 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is pretty much the case with all mria callbacks. mria_lib prints warnings in the log if the callback crashes and always returns ok.

zmstone
zmstone previously approved these changes May 12, 2026
@ieQu1 ieQu1 dismissed stale reviews from zmstone and thalesmg via e001889 May 12, 2026 17:56
@ieQu1 ieQu1 force-pushed the dev/on-heal-callback branch from da9c776 to e001889 Compare May 12, 2026 17:56
@coveralls
Copy link
Copy Markdown

Coverage Report for CI Build 1045

Warning

No base build found for commit 790a964 on main.
Coverage changes can't be calculated without a base build.
If a base build is processing, this comment will update automatically when it completes.

Coverage: 52.538%

Details

  • Patch coverage: 3 uncovered changes across 1 file (0 of 3 lines covered, 0.0%).

Uncovered Changes

File Changed Covered %
src/mria_autoheal.erl 3 0 0.0%

Coverage Regressions

Requires a base build to compare against. How to fix this →


Coverage Stats

Coverage Status
Relevant Lines: 2305
Covered Lines: 1211
Line Coverage: 52.54%
Coverage Strength: 1639.23 hits per line

💛 - Coveralls

@ieQu1 ieQu1 merged commit 898b904 into main May 12, 2026
2 checks passed
@ieQu1 ieQu1 deleted the dev/on-heal-callback branch May 12, 2026 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants