Add setup_db.py to provision per environment database and role#105
Merged
Conversation
Used to set up this environment's database on RDS.
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a new provisioning script to create (or ensure) an environment-specific Postgres role and database on a shared RDS instance, and includes it in the production container image so it can be executed in deployed environments.
Changes:
- Add
scripts/setup_db.pyto create the per-environment role/database and apply basic privileges. - Update
app/production.Dockerfileto copy the new setup script into the image alongside other operational scripts.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| scripts/setup_db.py | New Postgres provisioning script for per-environment role/database creation and permissions. |
| app/production.Dockerfile | Ensures the new provisioning script is present in the production image. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+49
to
+68
| cursor.execute(sql.SQL("GRANT {} TO CURRENT_USER").format(sql.Identifier(role))) | ||
| cursor.execute("SELECT 1 FROM pg_database WHERE datname = %s", (db_name,)) | ||
| if not cursor.fetchone(): | ||
| cursor.execute( | ||
| sql.SQL("CREATE DATABASE {} OWNER {}").format( | ||
| sql.Identifier(db_name), | ||
| sql.Identifier(role), | ||
| ) | ||
| ) | ||
| cursor.execute( | ||
| sql.SQL("REVOKE CONNECT ON DATABASE {} FROM PUBLIC").format( | ||
| sql.Identifier(db_name) | ||
| ) | ||
| ) | ||
| cursor.execute( | ||
| sql.SQL("GRANT CONNECT ON DATABASE {} TO {}").format( | ||
| sql.Identifier(db_name), | ||
| sql.Identifier(role), | ||
| ) | ||
| ) |
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Used to set up this environment's database on RDS.