DEVEX-780: fix race condition in php-common-bump workflow#103
DEVEX-780: fix race condition in php-common-bump workflow#103pdodgen-revparts merged 1 commit intomainfrom
Conversation
The php-common-bump workflow was failing when main moved during execution. This adds fetch + rebase before pushing with retry logic to handle concurrent pushes to main.
PR SummaryLow Risk Overview The commit step now exits early when there are no changes (still emitting the current SHA), and replaces the direct Written by Cursor Bugbot for commit 076d0ad. This will update automatically on new commits. Configure here. |
aspencer
left a comment
There was a problem hiding this comment.
The amount of logic in this github workflow made me raise my eyebrow. Makes me wonder if there's some sort of way to test these things.
But... I guess it's fine?
Description
Fix race condition in
php-common-bump.yamlthat causes workflow failures whenmainbranch moves during execution.Jira Issue: https://revolutionparts.atlassian.net/browse/DEVEX-780
Background
The
upgrade-commonworkflow in downstream repos (likebatch) was consistently failing with errors like:Root cause: The workflow does a simple
git push origin mainwhich fails if another commit lands onmainbetween checkout and push (typically ~1 minute window). This happens frequently when:Fix: Added fetch + rebase before pushing, with retry logic (up to 5 attempts) to handle concurrent pushes.
Testing Information
composer installandcomposer require