feat(wallpaper selector): add wallpaper selector menu#1820
feat(wallpaper selector): add wallpaper selector menu#1820end-4 merged 36 commits intoend-4:mainfrom
Conversation
|
i used it but for some reason its blank |
Weird, and ~/Pictures/wallpapers is populated with images? |
Yeah |
Weird, I just tried on a fresh install again and it works, and another user in the Discord tried it as well and it works? What is "blank" anyway? The wallpaper when you set it? Or like the actual menu, like it's not populated? Or are the images there, but just not loaded in correctly? There is a lazy loading function when Qml is still processing the thumbnails, if you open the selection menu and wait a couple seconds does it populate or no? |
end-4
left a comment
end-4
left a comment
There was a problem hiding this comment.
So in general two things
- Rename "wallpaper overview" to "wallpaper selector"
- Make it sufficiently flexible:
- Must have directory navigation and address bar
- Can have common xdg dirs on the left side (Downloads, Pictures, etc). This is very easy, can be done in this PR or later
|
|
Hey, How can i make this work with video wallpapers? When i apply the video wallpaper it just gets removed instantly. Thumbnail Issue: |
|
Thumbnail generation is to be added and video files are not yet supported |
|
damn this has turned into something so much better than sleex design, the custom file picker is 🔥 |
|
The last problem to solve is thumbnail maintenance: If image changes, the thumbnail should be regenerated |
|
I realized just generating the image is still not fully spec-compliant... anyone got an idea of what tool we could use? |
|
Would you have to do something similar to what i was doing with the other wallpaper selector? Also, currently, if you switch folders, and close the selector then open it again it opens to the previous folder instead of opening the Wallpapers folder. I think it should function this way |
The solution in your PR is even further away from being spec-compliant than what we have right now, but if you can make line 57 of Ricing is normally "It's my machine I can do weird shit" but this is rice is not going to run on only one single person's machine |
|
This one is interesting: https://github.com/difference-engine/thumbnail-generator-ubuntu It works, but only generates "normal" size thumbnails and there doesn't seem to be a flag Edit: I managed to add sizes in difference-engine/thumbnail-generator-ubuntu#11 ... I hope they still accept PRs after 5 years |
|
Since the script is small and the maintainers seem inactive to accept my PR I decided to just copy it over. So we're ready 🎉 It would be nice to have indeterminate progressbar while thumbnails are being generated, but for now this works |
|
It got merged? yay |
6 participants
Describe your changes
Implemented a Wallpaper Changer using the same style and theming as the Overview Module. It utilizes native Qs functions to generate thumbnails for display to the user, eliminating the need for additional scripts to generate thumbnails.
Incorporates lazy-loading to handle cases where a thumbnail hasn't been generated yet (which can occur with some 4K images during reading and resizing). Thumbnails fade in gradually. All my wallpapers are 1080p or 1440p, so they load instantly.
Users can select a new wallpaper using either arrow keys or the mouse. The feature integrates seamlessly with the current system by using switchwall.sh to apply the new wallpaper.
Added a keybind
(Super + Comma)to toggle the Wallpaper Selection Menu.Wallpapers are pulled from
~/Pictures/wallpapers.Is it ready? Questions/feedback needed?
Tested on a fresh install, works as intended.
2025-08-15.17-41-48.mp4