fix: Issue 306 - handle exceptions in ProgressReporter.Begin and add …#1
Open
HowardvanRooijen wants to merge 1 commit intomainfrom
Open
fix: Issue 306 - handle exceptions in ProgressReporter.Begin and add …#1HowardvanRooijen wants to merge 1 commit intomainfrom
HowardvanRooijen wants to merge 1 commit intomainfrom
Conversation
…verification tests
There was a problem hiding this comment.
Pull request overview
This pull request fixes Issue 306 by adding exception handling to ProgressReporter.Begin to gracefully handle clients that don't support the window/workDoneProgress/create method. When a client throws an exception during progress creation, the implementation now catches it and sets an internal flag to skip subsequent progress reporting operations.
Changes:
- Added try-catch block in
ProgressReporter.Beginto handle exceptions from unsupporting clients - Added comprehensive test suite for the exception handling behavior
- Updated project file to include the new test file
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/CSharpLanguageServer/Lsp/ProgressReporter.fs | Added exception handling around WindowWorkDoneProgressCreate to catch errors from clients that don't support progress reporting |
| tests/CSharpLanguageServer.Tests/ProgressReporterTests.fs | New test file with tests verifying exception handling and no-op behavior after failed initialization |
| tests/CSharpLanguageServer.Tests/CSharpLanguageServer.Tests.fsproj | Added reference to the new test file |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…verification tests