Skip to content

feat(ses)!: Third-party module exports#668

Merged
kriskowal merged 4 commits into
masterfrom
655-ses
Apr 16, 2021
Merged

feat(ses)!: Third-party module exports#668
kriskowal merged 4 commits into
masterfrom
655-ses

Conversation

@kriskowal

Copy link
Copy Markdown
Member

BREAKING CHANGE Third-party static module interface implementations must now explicitly list their exported names. For CommonJS, this implies using a heuristic static analysis of exports changes. Consequently, third-party modules can now participate in linkage with ESM including support for export * from './spec.cjs' and also named imports like import * from './spec.cjs'.

Part 1 of #666

Comment thread packages/ses/test/test-import-cjs.js
@kriskowal kriskowal disabled auto-merge April 15, 2021 21:54
@kriskowal kriskowal force-pushed the 655-ses branch 2 times, most recently from 37b20a8 to e03a577 Compare April 15, 2021 22:14

@erights erights left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment thread packages/ses/NEWS.md Outdated
Comment thread packages/ses/src/module-instance.js Outdated
Comment thread packages/ses/src/module-instance.js
Comment thread packages/ses/src/module-instance.js
Comment thread packages/ses/src/module-instance.js
@kriskowal kriskowal merged commit f0ec398 into master Apr 16, 2021
@kriskowal kriskowal deleted the 655-ses branch April 16, 2021 18:58
@kriskowal kriskowal linked an issue Apr 16, 2021 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Restore CommonJS to CompartmentMapper

2 participants