ci: fix docker image smoke test to use python --version#134
Open
nacholiya wants to merge 1 commit intoendomorphosis:mainfrom
Open
ci: fix docker image smoke test to use python --version#134nacholiya wants to merge 1 commit intoendomorphosis:mainfrom
nacholiya wants to merge 1 commit intoendomorphosis:mainfrom
Conversation
Owner
|
@nacholiya i am doing a significant amount of refactoring an integration of this package, and the ipfs_datasets_py, ipfs_accelerate_py, and swissknife to all work together. i will let you know when the integrations have gotten working well. |
Author
|
Thanks for the update, appreciate the context 👍 Let me know if you want me to rebase or adjust the PR later. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes CI failure in Docker image workflow caused by an invalid container smoke test.
Root Cause
The workflow attempted to run the image with
--help, but the container does not expose a CLI entrypoint.Fix
Replaced the smoke test with
python --versionto verify the container starts correctly.Fixes #133