Dependencies update. Restructure each page to be modularized. Refactor Scene Page and more#61
Open
Jlu18 wants to merge 24 commits intoengaging-computing:devfrom
Open
Dependencies update. Restructure each page to be modularized. Refactor Scene Page and more#61Jlu18 wants to merge 24 commits intoengaging-computing:devfrom
Jlu18 wants to merge 24 commits intoengaging-computing:devfrom
Conversation
…re the LoginPage class and functions. And change import syntax of mui icons at App.js
…directory to inside the pages
…ed Scene Page, by splitting to SceneList and SceneShow. Restructure SceneList so the Scenes are tabbed into user scenes and example scenes. Filter, actions, etc are still WIP.
banstack
approved these changes
Mar 2, 2022
Member
banstack
left a comment
banstack
left a comment
There was a problem hiding this comment.
Everything looks great to me I don't want to be nick-picky but there are a few lines commented (as shown below). If they're meant for future reference and not lines you forget to remove then its all good. 👍
|
|
||
| // //Extract uid(different from ids) from data we received | ||
| // let uids = ids.map(id=>data[id].uid); | ||
| // //Filter out the repeated uids and the uids isn't 1; |
Member
There was a problem hiding this comment.
Not sure if you've commented these for future reference but if not it would be good to remove these
|
|
||
| const CourseFilter = (props) => ( | ||
| <Filter {...props}> | ||
| {/* <TextInput label="Search" source="q" alwaysOn /> */} |
| <Create {...props}> | ||
| <SimpleForm toolbar={<RefExCreateToolbar />}> | ||
| <TextInput source="functionName" /> | ||
| {/* <TextInput source="info" /> */} |
jdones01
approved these changes
Mar 2, 2022
jdones01
left a comment
jdones01
left a comment
There was a problem hiding this comment.
Looks good, however, some things are scarce with comments, and some things have been commented out (without a note as to why they are still there and not deleted).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Bump node engine version from 10.13 to 12.18
Update to following dependencies:
Added two new dependencies:
Removed unused dependencies
File Structure Change:
Resource Pages
Scene Page
components folder
Further TODOs