Several changes to html pages stored in backend#337
Open
davidjonesma wants to merge 2 commits intoengaging-computing:devfrom
Open
Several changes to html pages stored in backend#337davidjonesma wants to merge 2 commits intoengaging-computing:devfrom
davidjonesma wants to merge 2 commits intoengaging-computing:devfrom
Conversation
Changed text in about page to be left aligned Changed the features segment in the about page to stop higlighting on click and hover Changed header for all html files on the backend to include a new scene and changed MYR to My Reality Changed Support page open source segment; users can look at code but cannot contribute unless they are part of ECG
davidjonesma
requested review from
a team,
banstack,
jf-kelly and
nkisari
and removed request for
a team
jf-kelly
reviewed
Jul 28, 2022
Contributor
jf-kelly
left a comment
jf-kelly
left a comment
There was a problem hiding this comment.
The changes look good to me, I like the new look. I left a few comments with minor changes, other than that it seems to be all set. I know you already previewed your changes, but maybe one more demo would be beneficial before release. Nice work!
| </div> | ||
| <p class="mb-1">MYR is built with WebVR and supports almost a wide range of devices ranging from cardboard | ||
| to full VR rig.</p> | ||
| <p class="mb-1">MYR is built with WebVR and supports almost a wide range of devices, including iPhone, Android, Laptops, Desktops, and VR.</p> |
Contributor
There was a problem hiding this comment.
Maybe get rid of the word 'almost'
| <div class="col-md"> | ||
| <div class="card"> | ||
| <img class="card-img-top" src="/img/north_campus.png" | ||
| alt="User Example - Queen Status by Shandira Ferguson"> |
Contributor
There was a problem hiding this comment.
I believe the alternate text should be changed, like in the public/about/index.html file
| <h3>Open Source</h3> | ||
| <p class="lead mb-0 ">Looking to contribute or extend MYR? Just curious about the code behind MYR? | ||
| <br />Head over to our | ||
| <p class="lead mb-0 ">Looking to explore the codebase behind myr? Check out our page! |
Contributor
There was a problem hiding this comment.
MYR should be capatalized
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changed wording for education segment in about page,
Changed text in about page to be left aligned,
Changed the features segment in the about page to stop higlighting on click and hover,
Changed header for all html files on the backend to include a new scene and changed MYR to My Reality,
Changed Support page open source segment; users can look at code but cannot contribute unless they are part of ECG