Moved about pages into the front end #640
Open
r-maradiaga wants to merge 13 commits intoengaging-computing:devfrom
Open
Moved about pages into the front end #640r-maradiaga wants to merge 13 commits intoengaging-computing:devfrom
r-maradiaga wants to merge 13 commits intoengaging-computing:devfrom
Conversation
…r styling. Included the images of the about pages in this commit.
… different footers and nav bars across MYR.
…o old ones found in the backend.
…ges to include the specific shade of MYR yellow.
…s routing and added logo image and header image.
…packages from the old commit in an attempt to clear the merge conflicts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Previously we had stored many of the footer pages in the backend. This change allows us to free up clutter in the backend. Additionally, it allows anybody to make changes much more efficiently than when it was on the backend. The only way to see the changes to your code was to open the html file and constantly reload the page to see the changes you made. Instead of that tedious process, you can just use an
npmcommand to see your changes in real time.The pages that were added were:
Additional changes were done to routes.js in order to use the pages in the frontend rather than the backend; fontawesome packages were added to add icons for some of the about images including brand images like linkedin and github for team members that had websites linked in their respective cards; added another folder to hold images of team members; a couple of changes were done to App.css because it was difficult to get the same effect using bootstrap classes. However, most of the styling changes were done using bootstrap because the css files are global across all MYR pages.
Preview
About page header:
Related Issue
Issue #216